Skip to content

persqueue: fix user agent counters (for 24-3) #10875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

persqueue: fix user agent counters (for 24-3) #10875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/services/deprecated/persqueue_v0/grpc_pq_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ void TReadSessionActor::RegisterSessions(const TActorContext& ctx) {
}

void TReadSessionActor::SetupBytesReadByUserAgentCounter() {
BytesReadByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
BytesReadByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents", false)
->GetSubgroup("host", "")
->GetSubgroup("protocol", "pqv0")
->GetSubgroup("consumer", ClientPath)
Expand Down
2 changes: 1 addition & 1 deletion ydb/services/deprecated/persqueue_v0/grpc_pq_write_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ void TWriteSessionActor::InitAfterDiscovery(const TActorContext& ctx) {


void TWriteSessionActor::SetupBytesWrittenByUserAgentCounter() {
BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents", false)
->GetSubgroup("host", "")
->GetSubgroup("protocol", "pqv0")
->GetSubgroup("topic", FullConverter->GetFederationPath())
Expand Down
2 changes: 1 addition & 1 deletion ydb/services/persqueue_v1/actors/read_session_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ void TReadSessionActor<UseMigrationProtocol>::Handle(typename TEvReadInit::TPtr&
template<bool UseMigrationProtocol>
void TReadSessionActor<UseMigrationProtocol>::SetupBytesReadByUserAgentCounter() {
static constexpr auto protocol = UseMigrationProtocol ? "pqv1" : "topic";
BytesReadByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
BytesReadByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents", false)
->GetSubgroup("host", "")
->GetSubgroup("protocol", protocol)
->GetSubgroup("consumer", ClientPath)
Expand Down
2 changes: 1 addition & 1 deletion ydb/services/persqueue_v1/actors/write_session_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ void TWriteSessionActor<UseMigrationProtocol>::InitAfterDiscovery(const TActorCo
template<bool UseMigrationProtocol>
void TWriteSessionActor<UseMigrationProtocol>::SetupBytesWrittenByUserAgentCounter(const TString& topicPath) {
static constexpr auto protocol = UseMigrationProtocol ? "pqv1" : "topic";
BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents", false)
->GetSubgroup("host", "")
->GetSubgroup("protocol", protocol)
->GetSubgroup("topic", topicPath)
Expand Down
Loading