Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

Сообщения для служебной партиции. Позволяют получить информацию о записанных данных

struct TSuccess {
TString SourceId;
ui64 MinSeqNo, MaxSeqNo;
NKikimrPQ::TPartitionKeyRange KeyRange;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут список ключей для ренейма, а не рендж. А лучше то, что в body лежит сразу

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил
1518b41

};

struct TEvGetWriteInfoResponse : public TEventLocal<TEvGetWriteInfoResponse, EvGetWriteInfoResponse> {
struct TError {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут надо сообщение об ошике, и его в Propose отдавать в итоге ( или в причине аборта транзакции)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил текст сообщения об ошибке

};

struct TSuccess {
TString SourceId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут вектор. Сорсидов может быть много.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил
1518b41

ui32 Cookie; // ShadowPartitionId
};

struct TEvGetWriteInfoResponse : public TEventLocal<TEvGetWriteInfoResponse, EvGetWriteInfoResponse> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split in 2 messages - writeinforesponse and writeinfoerror

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
7f74ed7

struct TSuccess {
THashMap<TString, NPQ::TSeqNoRange> SeqNo; // SourceId -> (MinSeqNo, MaxSeqNo)
std::deque<NPQ::TDataKey> BodyKeys;
std::deque<NPQ::TBatch> Head;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to list of messages (MsgWrite)

Copy link
Collaborator Author

@Alek5andr-Kotov Alek5andr-Kotov Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
00dee5e

{}
};

struct TDataKey {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Change caching proxy logic to process move commands too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to the task of transferring data

alexnick88
alexnick88 previously approved these changes Jan 26, 2024
@github-actions
Copy link

github-actions bot commented Jan 26, 2024

2024-01-26 09:36:55 UTC Pre-commit check for 9d469b9 has started.
2024-01-26 09:36:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-26 09:41:35 UTC Build successful.
2024-01-26 09:41:52 UTC Tests are running...
🔴 2024-01-26 11:18:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60159 50886 0 1 9245 27

@github-actions
Copy link

github-actions bot commented Jan 26, 2024

2024-01-26 09:37:09 UTC Pre-commit check for 9d469b9 has started.
2024-01-26 09:37:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-26 09:42:22 UTC Build successful.
2024-01-26 09:42:37 UTC Tests are running...
🔴 2024-01-26 11:28:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15957 15852 0 26 56 23

THashMap<TString, NPQ::TSeqNoRange> seqNo,
std::deque<NPQ::TDataKey> bodyKeys,
std::deque<NPQ::TBatch> head) :
TVector<NPQ::TClientBlob> head) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TVector && - будет лишнее копирование

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил
8fc84c4

@spuchin spuchin deleted the LOGBROKER-8878 branch February 9, 2024 17:59
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants