Skip to content

Conversation

@APozdniakov
Copy link
Member

Changelog entry

AFTER MATCH SKIP PAST LAST ROW is default option now

Changelog category

  • New feature

@APozdniakov APozdniakov self-assigned this Oct 18, 2024
@APozdniakov APozdniakov requested a review from a team as a code owner October 18, 2024 10:24
@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 10:28:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for a68943f has started.
2024-10-18 10:28:44 UTC Artifacts will be uploaded here
2024-10-18 10:31:52 UTC ya make is running...
🔴 2024-10-18 10:56:26 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 10:28:34 UTC Pre-commit check linux-x86_64-release-asan for a68943f has started.
2024-10-18 10:28:45 UTC Artifacts will be uploaded here
2024-10-18 10:31:55 UTC ya make is running...
🔴 2024-10-18 10:56:27 UTC Build failed, see the logs. Also see fail summary

@APozdniakov APozdniakov added the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:16:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for a68943f has started.
2024-10-18 11:16:20 UTC Artifacts will be uploaded here
2024-10-18 11:19:34 UTC ya make is running...
🔴 2024-10-18 11:24:32 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:16:34 UTC Pre-commit check linux-x86_64-release-asan for a68943f has started.
2024-10-18 11:16:45 UTC Artifacts will be uploaded here
2024-10-18 11:20:03 UTC ya make is running...
🔴 2024-10-18 11:28:16 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:48:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 134a01f has started.
2024-10-18 11:49:05 UTC Artifacts will be uploaded here
2024-10-18 11:52:21 UTC ya make is running...
🔴 2024-10-18 12:10:28 UTC Build failed, see the logs. Also see fail summary
🟢 2024-10-18 12:10:47 UTC ydbd size 2.8 GiB changed* by +8.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cebe29d merge: 134a01f diff diff %
ydbd size 3 012 456 960 Bytes 3 012 465 496 Bytes +8.3 KiB +0.000%
ydbd stripped size 477 649 976 Bytes 477 652 984 Bytes +2.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 11:49:02 UTC Pre-commit check linux-x86_64-release-asan for 134a01f has started.
2024-10-18 11:49:32 UTC Artifacts will be uploaded here
2024-10-18 11:53:09 UTC ya make is running...
2024-10-18 12:31:20 UTC Check cancelled

@APozdniakov APozdniakov added the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:33:05 UTC Pre-commit check linux-x86_64-release-asan for c4eb6d0 has started.
2024-10-18 12:33:16 UTC Artifacts will be uploaded here
2024-10-18 12:36:29 UTC ya make is running...
2024-10-18 13:24:44 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:33:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for c4eb6d0 has started.
2024-10-18 12:33:25 UTC Artifacts will be uploaded here
2024-10-18 12:36:36 UTC ya make is running...
🔴 2024-10-18 12:50:52 UTC Build failed, see the logs. Also see fail summary

@APozdniakov APozdniakov added the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 18, 2024
@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 13:27:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e9bb01 has started.
2024-10-18 13:27:13 UTC Artifacts will be uploaded here
2024-10-18 13:30:21 UTC ya make is running...
🟡 2024-10-18 14:41:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79597 65600 0 5 13896 96

2024-10-18 14:49:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 15:01:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 9 0 0 0 91

🟢 2024-10-18 15:01:23 UTC Build successful.
🟢 2024-10-18 15:01:40 UTC ydbd size 2.8 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: eb88635 merge: 1e9bb01 diff diff %
ydbd size 3 012 692 184 Bytes 3 012 693 952 Bytes +1.7 KiB +0.000%
ydbd stripped size 477 690 008 Bytes 477 691 544 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 13:27:15 UTC Pre-commit check linux-x86_64-release-asan for 1e9bb01 has started.
2024-10-18 13:27:26 UTC Artifacts will be uploaded here
2024-10-18 13:30:38 UTC ya make is running...
🟡 2024-10-18 15:15:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16653 16369 0 82 97 105

🟢 2024-10-18 15:16:45 UTC Build successful.
🟢 2024-10-18 15:17:19 UTC ydbd size 5.7 GiB changed* by +9.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: eb88635 merge: 1e9bb01 diff diff %
ydbd size 6 103 710 472 Bytes 6 103 720 312 Bytes +9.6 KiB +0.000%
ydbd stripped size 1 521 729 136 Bytes 1 521 733 360 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

const TArrayRef<std::pair<TStringBuf, TBinaryLambda>>& getMeasures,
const NYql::NMatchRecognize::TRowPattern& pattern,
const TArrayRef<std::pair<TStringBuf, TTernaryLambda>>& getDefines,
bool afterMatchSkipPastLastRow,
Copy link
Member

@rvu1024 rvu1024 Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Изменение интерфейса runtime ноды обычно сопровождается изменением runtime версии с обработкой обратной совместимости

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR включен только в YQ и паре ydb для Yaem. Возможно в этом случае можно не делать обратную совместимость?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обратная совместимость нужна для роллинг-апдейта кластера. Часть нодов будет старая, часть новая. Запросы от пользователя с любой версией могут прилететь на любую ноду

@github-actions
Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 13:46:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4412fa4 has started.
2024-10-21 13:47:10 UTC Artifacts will be uploaded here
2024-10-21 13:50:23 UTC ya make is running...
🟡 2024-10-21 15:03:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79502 65497 0 4 13907 94

2024-10-21 15:10:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 15:22:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 5 0 0 0 93

🟢 2024-10-21 15:22:19 UTC Build successful.
🟢 2024-10-21 15:22:48 UTC ydbd size 2.8 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 96d03d6 merge: 4412fa4 diff diff %
ydbd size 3 015 313 936 Bytes 3 015 319 784 Bytes +5.7 KiB +0.000%
ydbd stripped size 477 978 328 Bytes 477 983 960 Bytes +5.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 13:47:17 UTC Pre-commit check linux-x86_64-release-asan for 4412fa4 has started.
2024-10-21 13:47:27 UTC Artifacts will be uploaded here
2024-10-21 13:50:40 UTC ya make is running...
🟡 2024-10-21 15:29:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16483 16241 0 61 71 110

🟢 2024-10-21 15:30:45 UTC Build successful.
🟢 2024-10-21 15:31:20 UTC ydbd size 5.7 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e6f71f0 merge: 4412fa4 diff diff %
ydbd size 6 108 702 688 Bytes 6 108 714 528 Bytes +11.6 KiB +0.000%
ydbd stripped size 1 522 711 760 Bytes 1 522 716 240 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@APozdniakov APozdniakov added the rebase-and-check Rebase PR with the current base branch and check label Oct 22, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 22, 2024
@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 10:21:34 UTC Pre-commit check linux-x86_64-release-asan for 1f0ad4f has started.
2024-10-22 10:21:44 UTC Artifacts will be uploaded here
2024-10-22 10:24:59 UTC ya make is running...
🔴 2024-10-22 10:29:59 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 10:21:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1f0ad4f has started.
2024-10-22 10:22:04 UTC Artifacts will be uploaded here
2024-10-22 10:25:15 UTC ya make is running...
🔴 2024-10-22 10:28:06 UTC Build failed, see the logs. Also see fail summary

kardymonds
kardymonds previously approved these changes Oct 22, 2024
@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 13:22:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3921318 has started.
2024-10-22 13:22:53 UTC Artifacts will be uploaded here
2024-10-22 13:26:43 UTC ya make is running...
🟡 2024-10-22 14:40:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79515 65503 0 4 13908 100

2024-10-22 14:48:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-22 14:49:20 UTC ydbd size 2.8 GiB changed* by +4.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b8ba76e merge: 3921318 diff diff %
ydbd size 3 012 110 296 Bytes 3 012 115 120 Bytes +4.7 KiB +0.000%
ydbd stripped size 478 086 392 Bytes 478 088 504 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-22 14:49:22 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 13:23:35 UTC Pre-commit check linux-x86_64-release-asan for 3921318 has started.
2024-10-22 13:24:04 UTC Artifacts will be uploaded here
2024-10-22 13:27:46 UTC ya make is running...
2024-10-22 14:49:05 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 14:53:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for b10f687 has started.
2024-10-22 14:54:00 UTC Artifacts will be uploaded here
2024-10-22 14:57:14 UTC ya make is running...
🟡 2024-10-22 16:09:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79512 65504 0 7 13907 94

2024-10-22 16:17:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-22 16:28:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 7 0 0 0 93

🟢 2024-10-22 16:29:03 UTC Build successful.
🟢 2024-10-22 16:29:25 UTC ydbd size 2.8 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b8ba76e merge: b10f687 diff diff %
ydbd size 3 012 110 296 Bytes 3 012 112 768 Bytes +2.4 KiB +0.000%
ydbd stripped size 478 086 392 Bytes 478 088 376 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 14:54:02 UTC Pre-commit check linux-x86_64-release-asan for b10f687 has started.
2024-10-22 14:54:12 UTC Artifacts will be uploaded here
2024-10-22 14:57:28 UTC ya make is running...
🟡 2024-10-22 16:33:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16448 16229 0 50 66 103

🟢 2024-10-22 16:34:48 UTC Build successful.
🟢 2024-10-22 16:35:22 UTC ydbd size 5.7 GiB changed* by +17.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 799414a merge: b10f687 diff diff %
ydbd size 6 099 299 704 Bytes 6 099 317 256 Bytes +17.1 KiB +0.000%
ydbd stripped size 1 522 411 984 Bytes 1 522 421 840 Bytes +9.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@APozdniakov APozdniakov merged commit c8a32ef into ydb-platform:main Oct 22, 2024
10 checks passed
APozdniakov added a commit to APozdniakov/ydb that referenced this pull request Oct 22, 2024
APozdniakov added a commit to APozdniakov/ydb that referenced this pull request Oct 22, 2024
APozdniakov added a commit to APozdniakov/ydb that referenced this pull request Oct 22, 2024
@APozdniakov APozdniakov deleted the YQ-3621 branch February 25, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants