Skip to content

Don't use GetRawData for logging #10450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Oct 15, 2024

Changelog entry

https://nebius.atlassian.net/browse/NBYDB-475
don't use GetRawData for logging

Changelog category

Improvement

Additional information

Log example

2024-10-15T12:04:29.815256Z :MVP DEBUG: Can not process request to protected resource:
2024-10-15T12:04:29.815276Z :HTTP DEBUG: (#20,[2a13:5947:3:1009:2200:2604:9fae:f203]:39070) <- (400 Bad Request)
***
authorization: <obfuscated>

@StekPerepolnen StekPerepolnen changed the title mask iam tokens http oidc Don't use GetRawData for logging Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 11:54:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 95a8b6e has started.
2024-10-15 11:54:32 UTC Artifacts will be uploaded here
2024-10-15 11:57:34 UTC ya make is running...
🔴 2024-10-15 12:03:26 UTC Build failed, see the logs.

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 11:57:11 UTC Pre-commit check linux-x86_64-release-asan for 95a8b6e has started.
2024-10-15 11:57:22 UTC Artifacts will be uploaded here
2024-10-15 12:00:24 UTC ya make is running...
🔴 2024-10-15 12:06:18 UTC Build failed, see the logs.

@StekPerepolnen StekPerepolnen force-pushed the mask-iam-tokens-http-oidc branch 2 times, most recently from 9905848 to 6662ccc Compare October 15, 2024 13:02
@StekPerepolnen StekPerepolnen requested a review from a team as a code owner October 15, 2024 13:02
Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 13:04:29 UTC Pre-commit check linux-x86_64-release-asan for a1d5e28 has started.
2024-10-15 13:06:57 UTC Artifacts will be uploaded here
2024-10-15 13:10:50 UTC ya make is running...
2024-10-15 14:39:55 UTC Check cancelled

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 13:04:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for a1d5e28 has started.
2024-10-15 13:04:47 UTC Artifacts will be uploaded here
2024-10-15 13:07:45 UTC ya make is running...
🟡 2024-10-15 14:35:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75001 61022 0 3 13871 105

🟢 2024-10-15 14:40:10 UTC ydbd size 2.8 GiB changed* by +12.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1035af merge: a1d5e28 diff diff %
ydbd size 3 010 572 128 Bytes 3 010 585 056 Bytes +12.6 KiB +0.000%
ydbd stripped size 477 545 624 Bytes 477 545 688 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-15 14:40:11 UTC Check cancelled

uzhastik
uzhastik previously approved these changes Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 14:42:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81050d9 has started.
2024-10-15 14:42:11 UTC Artifacts will be uploaded here
2024-10-15 14:45:13 UTC ya make is running...
🟢 2024-10-15 15:52:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75000 61025 0 0 13871 104

🟢 2024-10-15 15:59:50 UTC Build successful.
🟢 2024-10-15 16:00:08 UTC ydbd size 2.8 GiB changed* by +12.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 168df93 merge: 81050d9 diff diff %
ydbd size 3 010 622 856 Bytes 3 010 635 784 Bytes +12.6 KiB +0.000%
ydbd stripped size 477 552 728 Bytes 477 552 792 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 14:43:02 UTC Pre-commit check linux-x86_64-release-asan for 81050d9 has started.
2024-10-15 14:43:13 UTC Artifacts will be uploaded here
2024-10-15 14:46:14 UTC ya make is running...
🟡 2024-10-15 16:18:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12125 11735 0 67 279 44

🟢 2024-10-15 16:19:33 UTC Build successful.
🟢 2024-10-15 16:20:35 UTC ydbd size 5.7 GiB changed* by +43.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 168df93 merge: 81050d9 diff diff %
ydbd size 6 099 277 304 Bytes 6 099 321 304 Bytes +43.0 KiB +0.001%
ydbd stripped size 1 521 027 088 Bytes 1 521 027 472 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen merged commit b390c9d into ydb-platform:main Oct 15, 2024
10 checks passed
@StekPerepolnen StekPerepolnen deleted the mask-iam-tokens-http-oidc branch October 15, 2024 18:24
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants