Skip to content

Fixed ToBytes/FromBytes for decimal & big tz dates #10348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Oct 11, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@vitstn vitstn requested a review from a team as a code owner October 11, 2024 13:37
@vitstn vitstn requested a review from nepal October 11, 2024 13:38
@vitstn vitstn added the area/yql YQL query language issues label Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 13:40:35 UTC Pre-commit check linux-x86_64-release-asan for 9c6f0ae has started.
2024-10-11 13:40:46 UTC Artifacts will be uploaded here
2024-10-11 13:43:52 UTC ya make is running...
🔴 2024-10-11 14:07:39 UTC Build failed, see the logs.

Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 13:40:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c6f0ae has started.
2024-10-11 13:40:49 UTC Artifacts will be uploaded here
2024-10-11 13:43:57 UTC ya make is running...
🔴 2024-10-11 14:10:39 UTC Build failed, see the logs.

Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 15:17:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 780459b has started.
2024-10-11 15:17:24 UTC Artifacts will be uploaded here
2024-10-11 15:20:30 UTC ya make is running...
🟡 2024-10-11 16:32:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79750 65775 0 15 13858 102

2024-10-11 16:40:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-11 16:52:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 7 0 9 0 99

2024-10-11 16:53:06 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-11 17:04:29 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 2 0 9 0 97

🟢 2024-10-11 17:04:36 UTC Build successful.
🟢 2024-10-11 17:04:59 UTC ydbd size 2.8 GiB changed* by +57.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 65aa640 merge: 780459b diff diff %
ydbd size 3 013 813 416 Bytes 3 013 872 512 Bytes +57.7 KiB +0.002%
ydbd stripped size 477 827 832 Bytes 477 841 656 Bytes +13.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

rvu1024
rvu1024 previously approved these changes Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 15:17:41 UTC Pre-commit check linux-x86_64-release-asan for 780459b has started.
2024-10-11 15:17:52 UTC Artifacts will be uploaded here
2024-10-11 15:20:58 UTC ya make is running...
🟡 2024-10-11 17:01:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16882 16610 0 66 99 107

🟢 2024-10-11 17:03:18 UTC Build successful.
🟢 2024-10-11 17:03:58 UTC ydbd size 5.7 GiB changed* by +99.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 65aa640 merge: 780459b diff diff %
ydbd size 6 107 595 736 Bytes 6 107 697 104 Bytes +99.0 KiB +0.002%
ydbd stripped size 1 521 855 632 Bytes 1 521 899 472 Bytes +42.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) October 11, 2024 16:22
Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 17:56:00 UTC Pre-commit check linux-x86_64-release-asan for 04cadcb has started.
2024-10-11 17:56:28 UTC Artifacts will be uploaded here
2024-10-11 18:00:05 UTC ya make is running...
🟡 2024-10-11 19:26:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16878 16635 0 59 80 104

🟢 2024-10-11 19:28:04 UTC Build successful.
🟢 2024-10-11 19:28:36 UTC ydbd size 5.7 GiB changed* by +99.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0eb2fea merge: 04cadcb diff diff %
ydbd size 6 107 655 272 Bytes 6 107 756 632 Bytes +99.0 KiB +0.002%
ydbd stripped size 1 521 848 656 Bytes 1 521 892 496 Bytes +42.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 11, 2024

2024-10-11 17:57:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 04cadcb has started.
2024-10-11 17:57:33 UTC Artifacts will be uploaded here
2024-10-11 18:00:39 UTC ya make is running...
🟡 2024-10-11 19:01:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79750 65782 0 4 13858 106

2024-10-11 19:08:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-11 19:19:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 7 0 0 1 101

🟢 2024-10-11 19:19:58 UTC Build successful.
🟢 2024-10-11 19:20:19 UTC ydbd size 2.8 GiB changed* by +57.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0eb2fea merge: 04cadcb diff diff %
ydbd size 3 013 825 176 Bytes 3 013 884 272 Bytes +57.7 KiB +0.002%
ydbd stripped size 477 811 576 Bytes 477 825 400 Bytes +13.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn requested a review from rvu1024 October 11, 2024 17:59
@vitstn vitstn merged commit ec35b6a into ydb-platform:main Oct 13, 2024
10 checks passed
@vitstn vitstn deleted the decimal_bigtz_bytes branch October 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants