-
Notifications
You must be signed in to change notification settings - Fork 735
Use DWARF symbols in backtrace only on Linux #10046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| tcmalloc.cpp | ||
| ) | ||
|
|
||
| IF (OS_LINUX AND ARCH_X86_64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну как-то консистентно: здесь написано "линукс и 64 бита", а внутри кода "юникс". Как будто если будем собирать под мак -- оно сломается, так как нет пирдира на library/cpp/dwarf_backtrace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Возможно более бы корректно выставлять на уровне ямэйка дефайн USE_DWARF_BACKTRACE, а в коде на основе него принимать решение -- будет одно место где принимаем решение
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category