Skip to content

Fix ListFromRange signatures in docs #10014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix ListFromRange signatures in docs #10014

merged 1 commit into from
Nov 29, 2024

Conversation

@igormunkin
Copy link
Collaborator

@igormunkin igormunkin commented Oct 2, 2024 •
edited by blinkov
Loading

The reference for ListFromRange builtin is missing the signature for parameters being optional YQL type. This specialization is worth mentioning since in that case the optional type is propagated further to the ListFromRange resulting type.

Changelog category

  • Documentation

@igormunkin igormunkin self-assigned this Oct 2, 2024
@github-actions github-actions bot added the bugfix label Oct 2, 2024
@github-actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

⚪ 2024-10-02 18:35:03 UTC Pre-commit check linux-x86_64-release-asan for 7e29d4f has started.
⚪ 2024-10-02 18:35:13 UTC Artifacts will be uploaded here
⚪ 2024-10-02 18:37:34 UTC ya make is running...
🟢 2024-10-02 18:38:55 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-10-02 18:39:00 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

⚪ 2024-10-02 18:35:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e29d4f has started.
⚪ 2024-10-02 18:35:20 UTC Artifacts will be uploaded here
⚪ 2024-10-02 18:37:41 UTC ya make is running...
🟢 2024-10-02 18:39:00 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-10-02 18:39:05 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@igormunkin igormunkin marked this pull request as ready for review October 21, 2024 07:21
@igormunkin igormunkin requested a review from a team as a code owner October 21, 2024 07:21
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed bugfix labels Oct 23, 2024
blinkov
blinkov reviewed Oct 23, 2024
View reviewed changes
ydb/docs/ru/core/yql/reference/yql-core/builtins/_includes/list.md Outdated
Comment on lines 752 to 753
ListFromRange(T, T)->LazyList<T> -- T - числовой тип или тип, представляющий дату/время
ListFromRange(T?, T?)->LazyList<T>? -- T - числовой тип или тип, представляющий дату/время
Copy link
Member

@blinkov blinkov Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ListFromRange(T, T)->LazyList<T> -- T - числовой тип или тип, представляющий дату/время
ListFromRange(T?, T?)->LazyList<T>? -- T - числовой тип или тип, представляющий дату/время
ListFromRange(T{Flags:AutoMap}, T{Flags:AutoMap}, T?)->LazyList<T> -- T — числовой тип
ListFromRange(T{Flags:AutoMap}, T{Flags:AutoMap}, I?)->LazyList<T> -- T — тип, представляющий дату/время, I — интервал

Copy link
Member

@blinkov blinkov Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

плюс в английской версии нужно аналогично

Copy link
Member

@blinkov blinkov Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igormunkin ping

Copy link
Collaborator Author

@igormunkin igormunkin Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blinkov, applied your suggestions here: 7c6fe18.

@igormunkin
Fix ListFromRange signatures in docs
7c6fe18 
The reference for <ListFromRange> builtin is missing the signature for
parameters being optional YQL type. This specialization is worth
mentioning since in that case the optional type is propagated further to
the <ListFromRange> resulting type.
@igormunkin igormunkin requested a review from blinkov November 12, 2024 09:24
@github-actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 09:25:23 UTC Pre-commit check linux-x86_64-release-asan for fd3a748 has started.
⚪ 2024-11-12 09:25:34 UTC Artifacts will be uploaded here
⚪ 2024-11-12 09:28:06 UTC ya make is running...
🟢 2024-11-12 09:29:28 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-12 09:29:34 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 09:25:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd3a748 has started.
⚪ 2024-11-12 09:25:58 UTC Artifacts will be uploaded here
⚪ 2024-11-12 09:28:43 UTC ya make is running...
🟢 2024-11-12 09:30:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-12 09:30:13 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov enabled auto-merge (squash) November 29, 2024 06:17
@blinkov blinkov merged commit c52270b into ydb-platform:main Nov 29, 2024
11 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
@igormunkin igormunkin deleted the docs/fix-ListFromRange-signature branch December 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@blinkov blinkov Awaiting requested review from blinkov

Assignees

@igormunkin igormunkin

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igormunkin @blinkov @fomichev3000