Skip to content

fix error message logging #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix error message logging #93

merged 2 commits into from
Jan 10, 2023

Conversation

VasilyStepanov
Copy link
Contributor

response.text() is async here, so without await we will get:

Error while getting token from metadata: <coroutine object ClientResponse.text at 0x7f6958452140>

@rekby
Copy link
Member

rekby commented Jan 10, 2023

@VasilyStepanov, hello.

Thanks for the fix.

Do you agree with Yandex Contributor License Agreement
https://yandex.ru/legal/cla/?lang=en (in English) and https://yandex.ru/legal/cla/?lang=ru (in Russian).

?

@VasilyStepanov
Copy link
Contributor Author

Do you agree with Yandex Contributor License Agreement https://yandex.ru/legal/cla/?lang=en (in English) and https://yandex.ru/legal/cla/?lang=ru (in Russian).

?

Yes!

@rekby
Copy link
Member

rekby commented Jan 10, 2023

It's perfect!

Fix style issue please:

-                        "Error while getting token from metadata: %s" % await response.text()
+                        "Error while getting token from metadata: %s"
+                        % await response.text()

@rekby rekby merged commit 62c28b2 into ydb-platform:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants