Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple handler for topic's internal retryable streams #371

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Feb 10, 2025

fixes #370

@alex268 alex268 requested a review from pnv1 February 10, 2025 13:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.39%. Comparing base (bc59ac1) to head (eabb8fb).

Files with missing lines Patch % Lines
...in/java/tech/ydb/topic/impl/GrpcStreamRetrier.java 50.00% 2 Missing ⚠️
...n/java/tech/ydb/topic/settings/ReaderSettings.java 60.00% 2 Missing ⚠️
...n/java/tech/ydb/topic/settings/WriterSettings.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
- Coverage     58.39%   58.39%   -0.01%     
- Complexity     2092     2094       +2     
============================================
  Files           312      312              
  Lines         12610    12623      +13     
  Branches       1246     1247       +1     
============================================
+ Hits           7364     7371       +7     
- Misses         4648     4654       +6     
  Partials        598      598              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit b3c7fd6 into ydb-platform:master Feb 10, 2025
8 checks passed
@alex268 alex268 deleted the add_retry_handler branch February 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user defined handler of error statuses to topic readers/writers
3 participants