Skip to content

fix: fix slashes everywhere #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: fix slashes everywhere #2244

wants to merge 4 commits into from

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 30, 2025

Closes #2091

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.47 MB | Main: 83.47 MB
Diff: +0.17 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix slash inconsistencies in schema and breadcrumb handling.

  • Introduces a helper function (prepareSchemaRootName) in ObjectTree.tsx to ensure the schema root name always starts with a slash.
  • Removes the prepareTenantName function in breadcrumbs.tsx to stop stripping leading slashes from tenant names.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/containers/Tenant/ObjectSummary/ObjectTree.tsx Adds prepareSchemaRootName to enforce a leading slash on root names.
src/containers/Header/breadcrumbs.tsx Removes prepareTenantName and adjusts tenant name display in breadcrumbs.
Comments suppressed due to low confidence (1)

src/containers/Header/breadcrumbs.tsx:65

  • [nitpick] Removing the function that strips a leading slash changes the tenant breadcrumb display. Verify that preserving the leading slash in tenantName aligns with the intended UI design and maintains consistency across the application.
const text = tenantName ? tenantName : headerKeyset('breadcrumbs.tenant');

@astandrik astandrik requested a review from Copilot April 30, 2025 16:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the issue of inconsistent slashes in path strings across components. The key changes include:

  • Introducing the prepareSchemaRootName helper function in ObjectTree.tsx to ensure path strings start with a slash.
  • Updating the ObjectTree component to use the new helper function.
  • Removing the prepareTenantName function in breadcrumbs.tsx to prevent unintended modification of tenantName slashes.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/containers/Tenant/ObjectSummary/ObjectTree.tsx Added a helper function to prefix slashes to schema names and updated its usage when passing rootName to SchemaTree.
src/containers/Header/breadcrumbs.tsx Removed the function that stripped leading slashes from tenant names, relying instead on the original tenantName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix slashes everywhere
2 participants