Skip to content

fix: fix top shards path column and better overriding for advisor #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 23, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.36 MB | Main: 83.36 MB
Diff: +0.30 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the top shards path column by renaming its alias and improves the column overriding mechanism for the advisor view.

  • Fix alias naming in the shard query to "RelativePath".
  • Replace the "columns" prop with "overrideColumns" in the ShardsTable component to enhance column customization.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/store/reducers/tenantOverview/topShards/tenantOverviewTopShards.ts Renamed the SQL alias from "Path" to "RelativePath" for clarity in the query output.
src/components/ShardsTable/ShardsTable.tsx Updated the component props to use "overrideColumns" for overriding default columns and adjusted the dependency array accordingly.

@astandrik astandrik added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 57df88b Apr 23, 2025
5 checks passed
@astandrik astandrik deleted the astandrik.fix-topshards-path branch April 23, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants