fix: unnecessary background refresh on query page #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
force-pushed
the
astandrik.unnecessary-background-refresh-on-query-page-1210-2
branch
from
651730c to
e16eb71
Compare
ValeraS
requested changes
Sep 6, 2024
Raubzeug
requested changes
Sep 10, 2024
|
|
||
| return ( | ||
| <React.Fragment> | ||
| <ElapsedTime className={b('elapsed-time')} /> |
There was a problem hiding this comment.
As for me ElapsedTime should not be a part of CancelQueryButton.
| import ElapsedTime from '../../../../components/ElapsedTime/ElapsedTime'; | ||
| import {cancelQueryApi} from '../../../../store/reducers/cancelQuery'; | ||
| import {cn} from '../../../../utils/cn'; | ||
| import i18n from '../i18n'; |
There was a problem hiding this comment.
lets do i18n for this component separately
There was a problem hiding this comment.
why?
we have all actions there
| if (resultType === RESULT_TYPES.EXPLAIN) { | ||
| const {plan, ast, simplifiedPlan} = explainQueryData || {}; | ||
| if (result?.type === ResultType.EXPLAIN) { | ||
| const {plan, ast, simplifiedPlan} = result.data || {}; |
There was a problem hiding this comment.
if we pass result as a property, whats the use is passing it's attributes one more time?
| showPreview, | ||
| } = props; | ||
| const {tenantPath: savedPath} = executeQuery; | ||
|
|
||
| const [resultType, setResultType] = React.useState<ValueOf<typeof RESULT_TYPES>>(); | ||
| const [isResultLoaded, setIsResultLoaded] = React.useState(false); | ||
| const isResultLoaded = Boolean(executeQuery.result); |
There was a problem hiding this comment.
why only executeQuery.result?
There was a problem hiding this comment.
executeQuery.result can be both execute or explain type
| @@ -335,7 +325,7 @@ function QueryEditor(props: QueryEditorProps) { | |||
| <QueryEditorControls | |||
| handleSendExecuteClick={handleSendExecuteClick} | |||
| onSettingsButtonClick={handleSettingsClick} | |||
| isLoading={explainQueryResult.isLoading || executeQueryResult.isLoading} | |||
| isLoading={Boolean(executeQuery.result?.isLoading)} | |||
There was a problem hiding this comment.
executeQuery.result can be both execute or explain type
ValeraS
requested changes
Sep 10, 2024
src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.tsx
Outdated
Show resolved
Hide resolved
ValeraS
reviewed
Sep 10, 2024
Raubzeug
approved these changes
Sep 12, 2024
ValeraS
approved these changes
Sep 12, 2024
astandrik
deleted the
astandrik.unnecessary-background-refresh-on-query-page-1210-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
Closes #1210
need to redo #1198
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 78.86 MB | Main: 78.86 MB
Diff: 0.00 MB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information