Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visions integration #570

Merged
merged 35 commits into from
Jan 5, 2021
Merged

Visions integration #570

merged 35 commits into from
Jan 5, 2021

Conversation

sbrugman
Copy link
Collaborator

@sbrugman sbrugman commented Sep 4, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #570 (c0f6525) into develop (8b185ab) will increase coverage by 1.44%.
The diff coverage is 93.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #570      +/-   ##
===========================================
+ Coverage    87.95%   89.40%   +1.44%     
===========================================
  Files          122      132      +10     
  Lines         3164     3699     +535     
===========================================
+ Hits          2783     3307     +524     
- Misses         381      392      +11     
Flag Coverage Δ
examples ?
issue ?
py3.6-macos-latest-pandas 89.21% <93.81%> (?)
py3.6-ubuntu-latest-pandas 89.21% <93.81%> (?)
py3.7-ubuntu-latest-pandas 89.21% <93.81%> (?)
py3.8-ubuntu-latest-pandas 89.40% <93.95%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
src/pandas_profiling/controller/console.py 96.15% <ø> (ø)
...profiling/report/presentation/flavours/__init__.py 100.00% <ø> (ø)
...profiling/report/presentation/flavours/flavours.py 72.72% <ø> (+12.72%) ⬆️
...iling/report/structure/variables/render_boolean.py 100.00% <ø> (ø)
...filing/report/structure/variables/render_common.py 100.00% <ø> (ø)
...iling/report/structure/variables/render_complex.py 25.00% <ø> (ø)
...ofiling/report/structure/variables/render_count.py 29.41% <ø> (+0.84%) ⬆️
...rofiling/report/structure/variables/render_date.py 100.00% <ø> (ø)
...rofiling/report/structure/variables/render_file.py 28.57% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d304ef...c0f6525. Read the comment docs.

@ieaves
Copy link
Contributor

ieaves commented Sep 17, 2020

Thanks for all of the collaboration getting this through Simon. A lot of hard work coming to fruition here.

@lgtm-com

This comment has been minimized.

@sbrugman sbrugman force-pushed the visions-integration branch from 16f5d48 to e1a8fa8 Compare November 19, 2020 22:43
@lgtm-com

This comment has been minimized.

@sbrugman sbrugman force-pushed the visions-integration branch from e1a8fa8 to 6eb0b95 Compare November 29, 2020 21:48
@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2020

This pull request introduces 12 alerts and fixes 1 when merging 87157e0 into f42174e - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 2 for Modification of parameter with default
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module-level cyclic import

@sbrugman sbrugman force-pushed the visions-integration branch from da38367 to a75fd17 Compare November 30, 2020 22:07
@sbrugman sbrugman force-pushed the visions-integration branch from a75fd17 to 176c355 Compare November 30, 2020 22:39
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 12 alerts and fixes 1 when merging 4192bb4 into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 2 for Modification of parameter with default
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 12 alerts and fixes 1 when merging a98142f into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 2 for Modification of parameter with default
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 12 alerts and fixes 1 when merging 7a079e5 into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 2 for Modification of parameter with default
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2020

This pull request introduces 8 alerts and fixes 1 when merging 172560a into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2020

This pull request introduces 8 alerts and fixes 1 when merging 22e1495 into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 13, 2020

This pull request introduces 9 alerts and fixes 1 when merging 373ac2b into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request introduces 9 alerts and fixes 1 when merging 1a19068 into 2d304ef - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Jan 4, 2021

This pull request introduces 7 alerts and fixes 1 when merging c0f6525 into 9ddf61f - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Module-level cyclic import

@sbrugman sbrugman merged commit d4e7018 into develop Jan 5, 2021
@sbrugman sbrugman deleted the visions-integration branch January 5, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants