Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static type checking #330

Merged
merged 7 commits into from
Feb 2, 2020
Merged

Static type checking #330

merged 7 commits into from
Feb 2, 2020

Conversation

sbrugman
Copy link
Collaborator

Introducing static type checking to this repository (#302). It finds some errors, it makes some errors.

sbrugman and others added 3 commits January 14, 2020 06:51
@sbrugman
Static type checking
b1e19c6 
Introducing static type checking to this repository (#302). It finds some errors, it makes some errors.
@sbrugman
Update requirements-test.txt
bc3fd60
@sbrugman
Merge branch 'master' into static-check
9ab12e1
@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6641201). Click here to learn what that means.
The diff coverage is 91.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage          ?   90.55%           
=========================================
  Files             ?       87           
  Lines             ?     1969           
  Branches          ?        0           
=========================================
  Hits              ?     1783           
  Misses            ?      186           
  Partials          ?        0
Flag Coverage Δ
#examples 30.39% <17.05%> (?)
#issue 81.08% <86.43%> (?)
#unit 84.37% <89.06%> (?)
Impacted Files Coverage Δ
tests/unit/test_console.py 100% <ø> (ø)
tests/issues/test_issue120.py 100% <ø> (ø)
tests/unit/test_describe.py 94% <ø> (ø)
src/pandas_profiling/model/base.py 93.33% <ø> (ø)
tests/unit/test_example.py 100% <ø> (ø)
tests/unit/test_modular.py 100% <ø> (ø)
tests/issues/test_issue147.py 100% <ø> (ø)
tests/unit/test_url.py 100% <ø> (ø)
tests/unit/test_output.py 100% <ø> (ø)
tests/issues/test_issue51.py 100% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6641201...3423ff4. Read the comment docs.

@sbrugman
Resolve some typing errors and removed f-strings for Python compatibi…
3e84d90 
…lity.

There are still errors when mypy requests Variable annotations (introduced Python 3.6).
@sbrugman sbrugman added this to the release-after-discontinuing-python3.5-support milestone Jan 19, 2020
@sbrugman sbrugman merged commit 2389d03 into master Feb 2, 2020
@sbrugman sbrugman deleted the static-check branch February 2, 2020 16:37
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this pull request Oct 11, 2020
@sbrugman
Static type checking (ydataai#330)
a5a2ab6 
Static type checking with `mypy`

Introducing static type checking to this repository (ydataai#302). 
The code base is updated to resolve detected typing errors.
A workaround is used to be compatible with Python 3.5, that does not support variable typing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbrugman