-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(display): Update display import #1709
fix(display): Update display import #1709
Conversation
…ction" This reverts commit 65e424c.
Hi @walterdiaza , thank you for your contribution! It seems like the unit testing is failing, as they need an update to be aligned with the changes that you've made. Nevertheless, I do have a question - In case users have an older version of IPython installed, would it still work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests update needed
Changes to the test notebooks (meteorites.ipynb, titanic.ipynb) are not necessary, they are causing the failures. Reverting them to their original state fixes the issue. And yes, it works for older versions of IPython, the tests running on python<3.11 cover that. |
The tests need to be updated.
Reverted to the original state or otherwise, the current PR needs to be updated so that the tests don't fail. @walterdiaza can you please perform the changes? |
Fix display import for IPython 9.0.0
Description
This PR primarily focuses on updating the display import to support IPython 9.0.0. Previously, we were using:
However, this is no longer compatible with IPython 9.0.0. We now import display from:
It's important to note that this module has been used in earlier versions of IPython as well, so this change does not break compatibility with previous releases.
Overall, these updates ensure full compatibility with the latest version of IPython while maintaining support for older versions . All modifications have been tested locally, and the expected behavior remains unchanged.
I appreciate your review and welcome any feedback or suggestions.
Fixes #1708