fix: table template ignoring text format #1462

alexbarros · 2023-09-26T14:05:03Z

closes #1437
Update the table template to use the string in its original format without overflowing.

codecov-commenter · 2023-09-26T16:05:28Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fdc0346) 89.49% compared to head (46a3057) 89.52%.
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1462      +/-   ##
===========================================
+ Coverage    89.49%   89.52%   +0.03%     
===========================================
  Files          194      194              
  Lines         6318     6337      +19     
===========================================
+ Hits          5654     5673      +19     
  Misses         664      664

Flag	Coverage Δ
py3.8-ubuntu-22.04-pandas	`89.52% <92.30%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/ydata_profiling/config.py	`99.55% <100.00%> (+<0.01%)`	⬆️
tests/unit/test_summary_algos.py	`100.00% <100.00%> (ø)`
tests/unit/test_time_series.py	`100.00% <ø> (ø)`
src/ydata_profiling/model/summary_algorithms.py	`73.86% <66.66%> (-0.30%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fix: table template ignoring text format * fix: timeseries unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai>

AmIIris · 2023-10-30T19:49:27Z

src/ydata_profiling/report/presentation/flavours/html/templates/table.html

@@ -18,11 +18,11 @@
                <tr{% if 'alert' in row and row['alert'] %} class="alert"{% endif %}>
                    <th>{{ row['name'] }}</th>
                    {% if row['value'].__class__.__name__ == 'list' %}
-                        {% for value in row['value'] %}
-                            <td>{{ value }}{% if loop.last and 'hint' in row %} {{ row['hint'] }}{% endif %}</td>
+                        {% for value in row['value'] +%}


I think the '+' sign should not be there? I'm recieving the error 'TemplateSyntaxError: unexpected 'end of statement block'' when running this code.

This breaking the render to html profile...

It's true, removing it fixed the HTML render

This error was fixed in #1491 and will be added to the next release

* Update duplicates_pandas.py (#1427) Fixing Bug Report #1384 Dataset with categorical features causes memory error even on tiny dataset. * chore(actions): update sonarsource/sonarqube-scan-action action to v2.0.1 * chore(actions): update actions/checkout action to v4 * docs: setup new docs with mkdocs (#1418) * chore(actions): update actions/checkout action to v4 * fix: remove the duplicated cardinality threshold under categorical and text settings * fix: fixate matplotlib upper version * docs: change from `zap` to `sparkles` (#1447) Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com> * fix: template {{ file_name }} error in HTML wrapper (#1380) * Update javascript.html * Update style.html * feat: add density histogram (#1458) * feat: add histogram density option * test: add unit test * fix: discard weights if exceed max_bins * docs: update README.html (#1461) Update url of use cases, main integrations, and common issues. * fix: bug when creating a new report (#1440) * fix: gen wordcloud only for non-empty cols (#1459) * fix: table template ignoring text format (#1462) * fix: table template ignoring text format * fix: timeseries unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai> * fix: to_category misshandling pd.NA (#1464) * docs: add 📊 for Key features (#1451) See also #1445 (comment) * docs: fix hyperlink - related to package name change (#1457) Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com> * chore(deps): increase numpy upper limit (#1467) * chore(deps): increase numpy upper limit * chore(deps): fixate numpy version for spark * chore(deps): fix numba package version, and filter warns (#1468) * chore: fix numba package version, and filter warns * fix: skip isort linter on init * chore(deps): update dependency typeguard to v4 (#1324) * chore(deps): update dependency typeguard to v4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maciej Bukczynski <maciej@darkhorseanalytics.com> * docs: update docs with advent of code * docs: update links for fabric --------- Co-authored-by: boris-kogan <139680785+boris-kogan@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vasco Ramos <vasco.ramos@ydata.ai> Co-authored-by: ricardodcpereira <ricardo.pereira@ydata.ai> Co-authored-by: Anselm Hahn <Anselm.Hahn@gmail.com> Co-authored-by: Joge <87136119+jogecodes@users.noreply.github.com> Co-authored-by: Alex Barros <alexbarros@users.noreply.github.com> Co-authored-by: Miriam Seoane Santos <68821478+miriamspsantos@users.noreply.github.com> Co-authored-by: Chris Mahoney <44449504+chrimaho@users.noreply.github.com> Co-authored-by: Azory YData Bot <azory@ydata.ai> Co-authored-by: martin-kokos <4807476+martin-kokos@users.noreply.github.com> Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com> Co-authored-by: Maciej Bukczynski <maciej@darkhorseanalytics.com> Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>

* Update duplicates_pandas.py (#1427) Fixing Bug Report #1384 Dataset with categorical features causes memory error even on tiny dataset. * chore(actions): update sonarsource/sonarqube-scan-action action to v2.0.1 * chore(actions): update actions/checkout action to v4 * docs: setup new docs with mkdocs (#1418) * chore(actions): update actions/checkout action to v4 * fix: remove the duplicated cardinality threshold under categorical and text settings * fix: fixate matplotlib upper version * docs: change from `zap` to `sparkles` (#1447) Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com> * fix: template {{ file_name }} error in HTML wrapper (#1380) * Update javascript.html * Update style.html * feat: add density histogram (#1458) * feat: add histogram density option * test: add unit test * fix: discard weights if exceed max_bins * docs: update README.html (#1461) Update url of use cases, main integrations, and common issues. * fix: bug when creating a new report (#1440) * fix: gen wordcloud only for non-empty cols (#1459) * fix: table template ignoring text format (#1462) * fix: table template ignoring text format * fix: timeseries unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai> * fix: to_category misshandling pd.NA (#1464) * docs: add 📊 for Key features (#1451) See also #1445 (comment) * docs: fix hyperlink - related to package name change (#1457) Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com> * chore(deps): increase numpy upper limit (#1467) * chore(deps): increase numpy upper limit * chore(deps): fixate numpy version for spark * chore(deps): fix numba package version, and filter warns (#1468) * chore: fix numba package version, and filter warns * fix: skip isort linter on init * chore(deps): update dependency typeguard to v4 (#1324) * chore(deps): update dependency typeguard to v4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maciej Bukczynski <maciej@darkhorseanalytics.com> * docs: update docs with advent of code * docs: update links for fabric * chore(actions): update actions/setup-python action to v5 * docs: add information about PII classification & management. --------- Co-authored-by: boris-kogan <139680785+boris-kogan@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vasco Ramos <vasco.ramos@ydata.ai> Co-authored-by: ricardodcpereira <ricardo.pereira@ydata.ai> Co-authored-by: Anselm Hahn <Anselm.Hahn@gmail.com> Co-authored-by: Joge <87136119+jogecodes@users.noreply.github.com> Co-authored-by: Alex Barros <alexbarros@users.noreply.github.com> Co-authored-by: Miriam Seoane Santos <68821478+miriamspsantos@users.noreply.github.com> Co-authored-by: Chris Mahoney <44449504+chrimaho@users.noreply.github.com> Co-authored-by: Azory YData Bot <azory@ydata.ai> Co-authored-by: martin-kokos <4807476+martin-kokos@users.noreply.github.com> Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com> Co-authored-by: Maciej Bukczynski <maciej@darkhorseanalytics.com> Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>

fix: table template ignoring text format

be1436b

alexbarros requested review from duartecsoares, aquemy and ricardodcpereira September 26, 2023 14:05

alexbarros mentioned this pull request Sep 26, 2023

data description not rendering line breaks in html output #1437

Closed

3 tasks

alexbarros and others added 2 commits September 26, 2023 12:29

fix: timeseries unit test

8def1ab

fix(linting): code formatting

46a3057

ricardodcpereira approved these changes Sep 26, 2023

View reviewed changes

aquemy approved these changes Sep 27, 2023

View reviewed changes

aquemy merged commit b7fac9e into develop Sep 27, 2023

aquemy deleted the fix/not_rendering_break_lines branch September 27, 2023 07:04

aquemy pushed a commit that referenced this pull request Oct 10, 2023

fix: table template ignoring text format (#1462)

7c41ca3

* fix: table template ignoring text format * fix: timeseries unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai>

aquemy pushed a commit that referenced this pull request Oct 10, 2023

fix: table template ignoring text format (#1462)

472c216

* fix: table template ignoring text format * fix: timeseries unit test * fix(linting): code formatting --------- Co-authored-by: Azory YData Bot <azory@ydata.ai>

AmIIris reviewed Oct 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: table template ignoring text format #1462

fix: table template ignoring text format #1462

alexbarros commented Sep 26, 2023

codecov-commenter commented Sep 26, 2023

AmIIris Oct 30, 2023

gariciodaro Oct 31, 2023

Ic3fr0g Nov 4, 2023

alexbarros Nov 7, 2023

fix: table template ignoring text format #1462

fix: table template ignoring text format #1462

Conversation

alexbarros commented Sep 26, 2023

codecov-commenter commented Sep 26, 2023

Codecov Report

AmIIris Oct 30, 2023

Choose a reason for hiding this comment

gariciodaro Oct 31, 2023

Choose a reason for hiding this comment

Ic3fr0g Nov 4, 2023

Choose a reason for hiding this comment

alexbarros Nov 7, 2023

Choose a reason for hiding this comment