Skip to content

Add debug logging for notification processing in Bullematic #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydah merged 1 commit into from
Jan 13, 2026
Merged

Add debug logging for notification processing in Bullematic #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions lib/bullematic/notifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,51 @@ def setup
def process_notifications
return unless defined?(Bullet) && Bullet.notification?

config = Bullematic.configuration
if config&.logger && config.debug
config.logger.debug "[Bullematic] Processing notifications..."
end

notifications = Bullet.send(:notification_collector)&.collection

if config&.logger && config.debug
config.logger.debug "[Bullematic] Notifications collection type: #{notifications.class}"
config.logger.debug "[Bullematic] Notifications count: #{notifications.respond_to?(:size) ? notifications.size : 'unknown'}"
end

n_plus_one_count = 0
unused_eager_loading_count = 0

case notifications
when Hash
notifications.each_value do |notification_set|
notification_set.each do |notification|
if notification.is_a?(Bullet::Notification::NPlusOneQuery)
n_plus_one_count += 1
process_n_plus_one(notification)
elsif notification.is_a?(Bullet::Notification::UnusedEagerLoading)
unused_eager_loading_count += 1
process_unused_eager_loading(notification)
end
end
end
when Enumerable
notifications.each do |notification|
if notification.is_a?(Bullet::Notification::NPlusOneQuery)
n_plus_one_count += 1
process_n_plus_one(notification)
elsif notification.is_a?(Bullet::Notification::UnusedEagerLoading)
unused_eager_loading_count += 1
process_unused_eager_loading(notification)
end
end
end

if config&.logger && config.debug
config.logger.debug "[Bullematic] Processed #{n_plus_one_count} N+1 notifications"
config.logger.debug "[Bullematic] Processed #{unused_eager_loading_count} UnusedEagerLoading notifications"
config.logger.debug "[Bullematic] Detection queue size: #{Fixer.detection_queue.size}"
end
end

private
Expand Down
Loading