Make mapping for YcmShowDetailedDiagnostic <silent>#4333
Open
Aster89 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4333 +/- ##
==========================================
+ Coverage 89.61% 89.67% +0.06%
==========================================
Files 37 37
Lines 4765 4765
==========================================
+ Hits 4270 4273 +3
+ Misses 495 492 -3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
This change is not necessary, but it's moderately useful in that it avoids the unnecessary visual noise of echoing
:YcmShowDetailedDiagnosticon the command line when triggering the detailed diagnostic popup, in the case that one has the following setting in placeRationale for not having a test
I think the change is uncontroversially useful, despite of very mild usefulness, and fundamentally safe. I don't think any existing reliance on this command not being
<silent>would be justifiable in the first place.This change is