Skip to content

Make mapping for YcmShowDetailedDiagnostic <silent>#4333

Open
Aster89 wants to merge 1 commit into
ycm-core:masterfrom
Aster89:silencing
Open

Make mapping for YcmShowDetailedDiagnostic <silent>#4333
Aster89 wants to merge 1 commit into
ycm-core:masterfrom
Aster89:silencing

Conversation

@Aster89

@Aster89 Aster89 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

This change is not necessary, but it's moderately useful in that it avoids the unnecessary visual noise of echoing :YcmShowDetailedDiagnostic on the command line when triggering the detailed diagnostic popup, in the case that one has the following setting in place

let g:ycm_show_detailed_diag_in_popup = 1

Rationale for not having a test

I think the change is uncontroversially useful, despite of very mild usefulness, and fundamentally safe. I don't think any existing reliance on this command not being <silent> would be justifiable in the first place.


This change is Reviewable

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (6a52780) to head (cbd4ceb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4333      +/-   ##
==========================================
+ Coverage   89.61%   89.67%   +0.06%     
==========================================
  Files          37       37              
  Lines        4765     4765              
==========================================
+ Hits         4270     4273       +3     
+ Misses        495      492       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant