feat: implement name-based secret resolution for Lockbox secrets #1034
Open
nikolaymatrosov wants to merge 2 commits intomainfrom
Open
feat: implement name-based secret resolution for Lockbox secrets #1034nikolaymatrosov wants to merge 2 commits intomainfrom
nikolaymatrosov wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive tests for the Lockbox secrets resolution logic and improves documentation formatting and clarity in the
README.md. The most significant changes are the addition of unit tests covering various scenarios for resolving Lockbox secrets, enhancements to the Lockbox service mock for better test coverage, and updates to the documentation for improved readability and accuracy.Testing improvements
__tests__/lockbox-secrets.test.tsto validate the behavior ofresolveLatestLockboxVersions, including cases for resolving "latest" version IDs, handling missing secrets, resolving by secret name, mixed resolution needs, and duplicate keys.__tests__/__mocks__/@yandex-cloud/nodejs-sdk/lockbox-v1.tsby adding support for secret list management, simulating failures, and supporting secret name lookups for more realistic and flexible testing.Documentation improvements
README.mdby switching code blocks to explicit language identifiers (e.g.,txt,yaml), fixing section headings, and clarifying the usage of Lockbox secrets and mounts. [1] [2] [3] [4] [5] [6]README.mdto clarify the difference between Lockbox access by ID and by name, and when each role is required.