disabled bitcode and automatic xCode / SDK detection #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for great tool to integrate Opus as xcframework!
Because latest commit is 3 years old, there were needed some fixes to make it working with latest xCode / SDK.
First, I added automatic xCode / SDK detection, so that there is no need to edit
iosSDKVersionandosxSDKVersionenv inprepare.sh. Then I also addedENABLE_BITCODE=NOintooptsinbuild.sh, because bitcode is not supported when using lib with xCode 16. I also removed legacy archs, that are not supported anymore in xCode 15 and above (i386 and armv7).And lastly, I have added
mkdirsforlibsandinclude, because without this, the script failed.