Skip to content

Commit

Permalink
fix(typescript): remove typescript from peer-deps (#685)
Browse files Browse the repository at this point in the history
Why?
----

The `typescript` package is required by the `@typescript-eslint/eslint-plugin` package.
So, this `eslint-config-ybiquitous` package does not need to require it as a peer dependency.
  • Loading branch information
ybiquitous authored Jul 4, 2020
1 parent 1f6c0bf commit 6214d93
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
4 changes: 2 additions & 2 deletions goodcheck.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
rules:
- id: update-peer-dependencies
pattern:
regexp: '"(eslint|prettier|typescript|@typescript-eslint/.+)": "[0-9.^~]+"'
glob: "package.json"
regexp: '"(eslint|prettier|@typescript-eslint/.+)": "[0-9.^~]+"'
glob: package.json
message: Don't forget updating `peerDependencies` when updating `devDependencies`.
justification:
- When not updating `peerDependencies`.
10 changes: 3 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,10 @@
"ybiq": "11.0.0"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": ">=2.33.0 <3",
"@typescript-eslint/parser": ">=2.33.0 <3",
"@typescript-eslint/eslint-plugin": ">=2.34.0 <3",
"@typescript-eslint/parser": ">=2.34.0 <3",
"eslint": ">=6.8.0 <7",
"prettier": ">=1.19.1 <3",
"typescript": ">=3.7.2 <4"
"prettier": ">=1.19.1 <3"
},
"peerDependenciesMeta": {
"@typescript-eslint/eslint-plugin": {
Expand All @@ -63,9 +62,6 @@
},
"prettier": {
"optional": false
},
"typescript": {
"optional": true
}
},
"scripts": {
Expand Down

0 comments on commit 6214d93

Please sign in to comment.