Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering glitches -- font glyphs drawn out of the cell bounds #164

Closed
jdhao opened this issue Oct 29, 2020 · 12 comments
Closed

Rendering glitches -- font glyphs drawn out of the cell bounds #164

jdhao opened this issue Oct 29, 2020 · 12 comments

Comments

@jdhao
Copy link

jdhao commented Oct 29, 2020

I am using fvim on Windows 10. I have noticed that fvim will show some glitches when I close another neovim window.

Steps to reproduce:

  • Open fvim: fvim -u NORC test.py
  • open the help window: :h help.
  • Close the help window: :quit.

Notice carefully that the previous fvim window has some noticeable glitches on the screen. Of course, using Ctrl-L will redraw the screen and clear them. But it is a little annoying.

P.S.: I can not reproduce this behavior when using nvim-qt using the same steps.

@yatli
Copy link
Owner

yatli commented Oct 29, 2020

Hi @jdhao thanks for reporting. I've been bugged by this too and it's font-specific.
With Iosevka Slab:h16 it does not repro with -NORC, but the problem still exists, especially for powerline symbols -- the glyphs are drawn out of the box.

A potential workaround is :FVimFontLineHeight "+1" (or -1, depends on your font)

I've yet to find a solution to this. Sometimes I adjust it so that it's good for one font but another breaks 😂

@jdhao
Copy link
Author

jdhao commented Oct 29, 2020

I am using Hack:h13 for fvim. Unfortunately, the trick does not work for me.🐈

@yatli
Copy link
Owner

yatli commented Oct 29, 2020

Could you capture a screenshot? If that doesn't work it may be a different issue.

@jdhao
Copy link
Author

jdhao commented Oct 29, 2020

@yatli sorry, I was doing it wrongly. I was using :FVimFontLineHeight +1 instead of :FVimFontLineHeight "+1". Using :FVimFontLineHeight "+1" fix the issue for me.

what is the difference between using the double quote and no double quote? I thought wrongly that they are the same... Fvim did not give any error when I omit the double quote.

jdhao added a commit to jdhao/nvim-config that referenced this issue Oct 29, 2020
@yatli
Copy link
Owner

yatli commented Oct 29, 2020

It's number vs string :)

:FVimFontLineHeight "+1" -- relative height +1, based on font height
:FVimFontLineHeight "16" -- absolute height 16

Cannot distinguish the two with numbers.

@yatli yatli changed the title small glitches when closing another neovim window Rendering glitches -- font glyphs drawn out of the cell bounds Oct 29, 2020
yatli pushed a commit that referenced this issue Nov 1, 2020
@yatli
Copy link
Owner

yatli commented Nov 1, 2020

@jdhao should be fixed now

@yatli yatli closed this as completed Nov 1, 2020
@jdhao
Copy link
Author

jdhao commented Nov 1, 2020

Thanks, will try tomorrow.

@jdhao
Copy link
Author

jdhao commented Nov 2, 2020

@yatli It seems that this commit hasn't been included in the latest release.

@yatli
Copy link
Owner

yatli commented Nov 2, 2020

try 0.2.306 😅

@jdhao
Copy link
Author

jdhao commented Nov 2, 2020

@yatli The newest release seems to have fixed the rendering glitch. Tried with fvim -u NORC.

@yatli
Copy link
Owner

yatli commented Nov 2, 2020

glad it really works!

@yatli
Copy link
Owner

yatli commented Nov 2, 2020

Version 0.2 is reaching a stable state.
I will be bumping the version to 0.3 once Avalonia v0.10 reaches GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants