forked from tensorflow/tensorboard
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Linked Time: Replace view encapsulation hack with
::ng-deep
(tensor…
…flow#6103) ## Motivation for features / changes tensorflow#6092 was pretty hacky and also didn't work internally ## Technical description of changes Apparently the pseudo selector ::ng-deep temporarily removes encapsulation and generally works better anyway. ## Screenshots of UI changes It works in OSS ![image](https://user-images.githubusercontent.com/78179109/207216000-4993095f-a419-4c10-9463-c57b7420e5dd.png) It works internally ![image](https://user-images.githubusercontent.com/78179109/207215848-fab8de51-38a6-45b5-a550-2f021306ef77.png) ## Detailed steps to verify changes work correctly (as executed by you) See tensorflow#6092
- Loading branch information
1 parent
62a54d3
commit ce9e45f
Showing
5 changed files
with
8 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 0 additions & 46 deletions
46
tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_unencapsulated.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters