Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download for rpm-groups.pot #28

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add download for rpm-groups.pot #28

merged 2 commits into from
Apr 11, 2019

Conversation

m-rey
Copy link
Contributor

@m-rey m-rey commented Apr 11, 2019

With this PR, an updated version of rpm-groups.pot from the https://github.com/openSUSE/packages-i18n repository is downloaded and used.

@lnussel
Copy link
Collaborator

lnussel commented Apr 11, 2019

👍

@lnussel
Copy link
Collaborator

lnussel commented Apr 11, 2019

@stanislav-brabec

@stanislav-brabec
Copy link
Collaborator

As I understand correctly, a new rpm-groups.pot generator was added to packages-i18n. Correct rpm-groups.pot is saved there, and here we want to import it and translate.

It is surely possible. We just have to remember that any we should never generate rpm-groups po files in packages-i18n (and not import them to Weblate).

There is another possibility: migrate rpm-groups to packages-i18n completely. But as po files there are used for a different purpose than installation of mo files, it would complicate the process.

So I agree.

The new script in yast-translations could be easily called on a regular basis.
@lslezak Is it possible to add its call to the Jenkins job?

@stanislav-brabec stanislav-brabec merged commit 6b1b0e3 into yast:master Apr 11, 2019
@stanislav-brabec
Copy link
Collaborator

The new script has a different string order. I did the first call and compared results. The new pot contains the same string set, just in a different order. There are only two exceptions, both are bugs.

@lnussel Please fix:
"Sources" × "sources" => "Sources"
"GUI" × "Gui" => "GUI"

Once it will be done, I will perform the call. It will generate a large diff, but no real changes, and no work for translators.

@lnussel
Copy link
Collaborator

lnussel commented Apr 12, 2019

Don't worry the old script wasn't called automatically either and was broken anyways. So should be ok to just track updating rpm-groups.pot in the project plan. It's not like rpm groups change often anyways :-)

Wrt to "sources" and "Gui". If the string appears in there I suppose there are packages that use those strings. @m-rey can you check which packages and fix them if it's wrong indeed?

@m-rey
Copy link
Contributor Author

m-rey commented Apr 12, 2019

I've tweaked the packages-i18n script to also output the package name in the comment line. Apparently, there are some packages that use "Gui" in the RPM group:

#. tumbleweed/plasma5-workspace/gmenudbusmenuproxy/group
#. tumbleweed/plasma5-workspace/xembedsniproxy/group
msgid "System/Gui/KDE"     
msgstr ""                          

And here's the package using "sources":

#. tumbleweed/grpc/grpc-source/group
msgid "Development/sources"         
msgstr ""                           

Also, there is a package using "Yast" instead of "YaST":

#. leap/yast2-alternatives/group      
#. tumbleweed/yast2-alternatives/group
msgid "System/Yast"                   
msgstr "" 

@lnussel
Copy link
Collaborator

lnussel commented Apr 12, 2019

there are actually tons of packages with invalid groups: https://rpmlint.opensuse.org/openSUSE:Factory/x86_64/standard?rule=non-standard-group so spelling mistakes is just one kind of error

@stanislav-brabec
Copy link
Collaborator

Fixed:
https://build.opensuse.org/request/show/693785
https://build.opensuse.org/request/show/693786
yast/yast-alternatives#43

I will manually edit the pot before commit, so we don't have to wait for check-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants