Installation Proposal BiDi fix (bsc#1089846) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the "SSH" BiDi text direction in the installation proposal https://bugzilla.suse.com/show_bug.cgi?id=1089846 Actually this is a workaround, it should not be necessary if there was a <div dir='rtl'>...</div> parent but this will be quicker.
mvidner
commented
Apr 23, 2018
|
|
||
| #. Returns the SSH-port part of the firewall proposal description | ||
| #. Returns nil if this part should be skipped | ||
| #. @return [String] proposal html text | ||
| #: src/lib/y2firewall/clients/proposal.rb:144 | ||
| msgid "SSH port will be open (<a href=\"%s\">block</a>)" | ||
| msgstr "SSH سيتم فتحه (<a href=\"%s\">أغلق</a>)" | ||
| msgstr "SSH سيتم فتحه (<a href=\"%s\">أغلق</a>)" |
There was a problem hiding this comment.
The GitHub rendered diff does not show any difference, but the actual change is adding a Right-To-Left mark (U+200F) at the beginning of the string, before "SSH" or "VNC" can establish a LTR direction.
|
I tested the fix using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the "SSH" BiDi text direction in the installation proposal
https://bugzilla.suse.com/show_bug.cgi?id=1089846
Actually this is a workaround, it should not be necessary if there was a
<div dir='rtl'>...</div>parent but this will be quicker.