Drop fbiterm in Tumbleweed Installation #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also openSUSE/installation-images#708 |
|
❌ Autosubmission job #9251920803 failed |
|
@lslezak : This is the example for CI via GitHub failing because the image doesn't have |
|
Submitted manually with |
|
I have added the |
|
✅ Autosubmission job #9251920803 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1224053
Trello
https://trello.com/c/haqsYySu
Problem
We are using fbiterm for much improved support for nontrivial locales like Chinese, Japanese, Korean in NCurses. But fbiterm is part of the xiterm package (it's the framebuffer version of xiterm, hence FB-Iterm) which has been abandoned upstream many years ago. With the upcoming GCC 14, it has build problems. The maintainer of the xiterm package feels unable to continue supporting it; so we need to drop the xiterm package and with it fbiterm.
Fix
Don't require xiterm in the YaST packages anymore.It turns out we never required xiterm or fbiterm in any YaST package: We always checked at runtime if
/usr/bin/fbitermwas available and used it only if it was.Don't use
fbitermin the YaST startup scripts anymore.Strictly speaking, we could simply rely on the check if it was available, but this PR cleans up a lot of legacy that goes back a long time, and that obscured the code in the startup scripts.
Caveat
Installing in certain languages won't work anymore in NCurses (text mode). Those languages will use a fallback to English from now on; but only in NCurses. The Qt (graphical) installation will work as before.
Target Distributions
For now, only Tumbleweed / Factory / YaST master is affected. SLE-15 SPx and SLE-12 SPx will retain fbiterm.
Test
Manual test in a modified inst-sys with the new scripts