zpm-config: accept numeric scalar values for interpolated settings#252
Open
hamidrezahanafi wants to merge 2 commits intoyarnpkg:mainfrom
Open
zpm-config: accept numeric scalar values for interpolated settings#252hamidrezahanafi wants to merge 2 commits intoyarnpkg:mainfrom
hamidrezahanafi wants to merge 2 commits intoyarnpkg:mainfrom
Conversation
Allow interpolated configuration fields to deserialize numeric YAML scalars by converting them to strings before parsing. This preserves existing string interpolation behavior while fixing configs like npmMinimalAgeGate: 0. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7853d62 |
⏱️ Benchmark Results
📊 Raw benchmark dataBase times: 2.771s, 2.604s, 2.564s, 2.483s, 2.554s, 2.567s, 2.607s, 2.514s, 2.571s, 2.470s, 2.522s, 2.536s, 2.620s, 2.445s, 2.511s, 2.559s, 2.556s, 2.517s, 2.605s, 2.547s, 2.524s, 2.543s, 2.534s, 2.430s, 2.309s, 2.531s, 2.556s, 2.477s, 2.522s, 2.302s Head times: 2.732s, 2.682s, 2.620s, 2.460s, 2.427s, 2.562s, 2.523s, 2.535s, 2.494s, 2.464s, 2.466s, 2.530s, 2.426s, 2.535s, 2.564s, 2.496s, 2.452s, 2.363s, 2.610s, 2.561s, 2.506s, 2.584s, 2.657s, 2.462s, 2.525s, 2.554s, 2.584s, 2.608s, 2.669s, 2.562s Benchmark: |
Add an acceptance test that writes npmMinimalAgeGate as a numeric YAML scalar in .yarnrc.yml and verifies install succeeds. This exercises file-based config parsing rather than env-based overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change needed?
npmMinimalAgeGate: 0inside.yarnrc.ymlcan't be parsed correctlySummary
Interpolated<T>deserialization to accept numeric YAML scalars in addition to stringsFromFileStringTest plan
cargo build --release -p zpmtests/acceptance-tests/pkg-tests-specs/sources/features/npmMinimalAgeGate.test.tsto add coverageMade with Cursor