Conversation
|
I'm not sure the implementation works well - if an error happens the generated file referenced in the error message will be empty, since we won't have been able to catch the output. What if instead we always generated a build log entry, which would then be rendered by the Report struct (similar to how it currently works for build error logs)? |
|
Good catch, though it would be nice to find a way to pipe the output to the terminal and to the logfile at the same time, as it's more user-friendly to display the output in real-time, especially on CI where things seem to take forever. |
There was a problem hiding this comment.
Bug: Inline Builds Disable Error Logging
When inline builds are enabled, shell forwarding is activated, which prevents stdout/stderr from being captured. This results in empty error log files when build scripts fail, as the logging mechanism attempts to write non-existent captured output, making debugging impossible.
packages/zpm/src/build.rs#L61-L62
Lines 61 to 62 in 5652a2a
Was this report helpful? Give feedback by reacting with 👍 or 👎
This PR implements Yarn's
enableInlineBuildsconfiguration option and the--inline-buildsflag for theinstallcommand.At the moment the lines aren't prefixed with
STDOUT/STDERR(like in Yarn) and don't exactly fit in nicely with the rest of the output, as the┌guidelines are missing.I'll leave those things for future PRs.