Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modifying .yarnrc if has hidden attr #8410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

audoh
Copy link

@audoh audoh commented Oct 23, 2020

Summary
When manually marked as hidden on Windows, trying to update .yarnrc with the latest lastUpdateCheck time caused an EPERM error to be printed to the console and the file to not be updated. As a result, yarn would attempt an update check on every run, instead of every day, slowing the install process for Windows users as well as printing the unsightly error message.

Linked issue: #4306

Test plan
With each test, the command yarn install was used.

  • Verified that the file is successfully created when .yarnrc does not exist.
  • Verified that the file is successfully modified when .yarnrc exists and is not hidden.
  • Verified that the file is successfully modified when .yarnrc exists and is hidden.
  • Verified that no error messages are printed.

@audoh audoh marked this pull request as draft October 25, 2020 17:53
@audoh audoh marked this pull request as ready for review February 27, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant