Skip to content

Conversation

@connectdotz
Copy link
Contributor

Summary

address #5579 related to #3986/#3996:
in order to prevent greedy workspaces.packages patterns to match unnecessary packages, #3996 added the node_modules/*/package.json pattern to exclude packages under the workspace package's node_modules folder. While sufficient for most use cases, it does not work for "deep" path such as "node_modules/X/Y/package.json". This PR replaced the shallow wildcard with globstar "**" so it will ignore all packages under the workspace package's node_modules folder.

  • Config.js: replace the shallow ignore pattern with a deep pattern.
  • execute-lifecycle-script: address when process.mainModule is undefined
  • tests: the rest are all tests.

Test plan

both new and old tests should pass

@connectdotz
Copy link
Contributor Author

ping @arslanarshad31 @bestander for comments

@arcanis
Copy link
Member

arcanis commented Apr 3, 2018

execute-lifecycle-script: address when process.mainModule is undefined

How did you hit this case? It should only be when using -e, -p, -r, right?

@connectdotz
Copy link
Contributor Author

connectdotz commented Apr 3, 2018

yarn test were failing with undefined process.mainModule

@arcanis
Copy link
Member

arcanis commented Apr 3, 2018

I see, probably a Flow update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants