fix workspace packages ignore-pattern #5607
Merged
+75
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address #5579 related to #3986/#3996:
in order to prevent greedy workspaces.packages patterns to match unnecessary packages, #3996 added the
node_modules/*/package.jsonpattern to exclude packages under the workspace package's node_modules folder. While sufficient for most use cases, it does not work for "deep" path such as "node_modules/X/Y/package.json". This PR replaced the shallow wildcard with globstar "**" so it will ignore all packages under the workspace package's node_modules folder.Test plan
both new and old tests should pass