fixed link and unlink cmd on windows (#4772) #5524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will increase the build size from 10.51 MB to 10.52 MB, an increase of 1.21 KB (0%)
|
|
Hi @xsbchen! Thanks for this contrib! Could you just write a new test to make sure we don't have regression on this later on? |
|
@arcanis test case had been added |
|
Some tests (including the new one) are consistently failing, can you give it a look? |
|
@arcanis done |
arcanis
approved these changes
Apr 5, 2018
|
Thanks 👍 |
This was referenced Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #4772
Test plan
existing and new tests should pass.