Fix yarn behaviour when scripts are failing #5497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #5451, #5457.
The test case in the first commit fails for pre-node5 builds, in the way described in the links issues. The problem are classes deriving from
Error, which are problematic in ES5 (babel). Addingbabel-plugin-transform-builtin-extendfixes the issue in this case.Why now?
The error surfaced because the current yarn build published on npm is a pre-node5 build while for example v1.3.1 seems to have been created by the more modern build configuration. This can be seen by checking if code like "class A extends B" got compiled to ES5 or not.