Skip to content

ci: use react with vite in storybook E2E #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jul 27, 2025

What's the problem this PR addresses?

The workflow .github/workflows/e2e-storybook-workflow.yml fails with

create-react-app is deprecated.

You can find a list of up-to-date React frameworks on react.dev
For more info see:https://react.dev/link/cra

This error message will only be shown once per install.
/tmp/xfs-1a340a15/dlx-2010/.pnp.cjs:5738
      throw EROFS(`open '${p}'`);

It was last successful on Dec 28, 2024.

How did you fix it?

In the workflow .github/workflows/e2e-storybook-workflow.yml

replace

yarn create react-app my-cra && cd my-cra

using

yarn create vite react --template react && cd react

Checklist

  • I have read the Contributing Guide.

  • I have set the packages that need to be released for my changes to be effective.

  • I will check that all automated PR checks pass before the PR gets reviewed.

@MikeMcC399
Copy link
Contributor Author

I'm not a Storybook user, but after waiting since Feb 2025 in the hope that somebody with Storybook experience would fix #6696, I decided I would try to find a solution. It looks like it works anyway!

https://github.com/yarnpkg/berry/actions/runs/16551577477/job/46807163529?pr=6864 is successful!

@MikeMcC399
Copy link
Contributor Author

@arcanis
You mentioned in Discord that you're preparing a new release. This PR isn't essential, but if it is merged it would tick off a failing workflow. You might like to take a look.

@arcanis arcanis merged commit f3b6af5 into yarnpkg:master Jul 30, 2025
27 checks passed
@arcanis
Copy link
Member

arcanis commented Jul 30, 2025

Thanks!

@MikeMcC399 MikeMcC399 deleted the fix/e2e-storybook branch July 30, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Workflow E2E Storybook fails with CRA deprecation warning and error EROFS
2 participants