Skip to content

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 17, 2025

What's the problem this PR addresses?

yarn test:lint

produces a warning

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.5.2

How did you fix it?

In packages/eslint-config update

Module From To
@typescript-eslint/eslint-plugin ^7.8.0 ^7.18.0
@typescript-eslint/parser ^7.8.0 ^7.18.0

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@MikeMcC399 MikeMcC399 changed the title Update/at typescript eslint chore(deps): update @typescript-eslint to 7.18.0 Feb 17, 2025
@MikeMcC399
Copy link
Contributor Author

To verify, run the following locally:

yarn test:lint

and confirm successful tests with no warnings. The warning doesn't seem to be displayed in CI.

@arcanis
Copy link
Member

arcanis commented Feb 17, 2025

Thanks! I'm migrating to ESLint 9 in #6694, it should fix it too

@MikeMcC399
Copy link
Contributor Author

@arcanis

Thanks! I'm migrating to ESLint 9 in #6694, it should fix it too

I was trying in small steps as I hadn't previously contributed here. 🙂

I will leave this PR in draft until #6694 is merged, then I would close it as superseded.

@arcanis arcanis mentioned this pull request Feb 17, 2025
3 tasks
arcanis added a commit that referenced this pull request Feb 17, 2025
## What's the problem this PR addresses?

We're still relying on ESLint 8, which isn't supported anymore.

Fixes #6687, #6689

Supercedes #6693

## How did you fix it?

This PR upgrades ESLint to its latest version, switching to the
stylistic rules when needed. No rules were removed.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
@MikeMcC399
Copy link
Contributor Author

@MikeMcC399 MikeMcC399 closed this Feb 17, 2025
@MikeMcC399 MikeMcC399 deleted the update/at-typescript-eslint branch February 17, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ESLint unsupported TypeScript 5.5 warning

2 participants