Skip to content

Fix CRA E2E test - #6423

Closed
clemyan wants to merge 3 commits into
masterfrom
clemyan/e2e/cra
Closed

clemyan wants to merge 3 commits into
masterfrom
clemyan/e2e/cra

Conversation

@clemyan

@clemyan clemyan commented Jul 30, 2024 •

Copy link
Copy Markdown
Member

What's the problem this PR addresses?

The CRA E2E test has been failing. CRA only supports ESLint up to v8

How did you fix it?

Stop installing eslint ourselves -- react-scripts depends on it already.

As far as I can tell, eslint-config-react-app also don't need to be installed explicitly now

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@clemyan
clemyan requested a review from arcanis as a code owner July 30, 2024 16:34
@clemyan
clemyan requested a review from merceyz July 30, 2024 16:45
@merceyz

merceyz commented Jul 30, 2024 •

Copy link
Copy Markdown
Member

Great that we don't need to install those ourselves anymore, we had to install both before (ref #3988).
We should remove it from

# TODO: Remove when create-react-app fixes their ESLint setup
yarn add -D eslint-config-react-app eslint
and
# TODO: Remove when create-react-app fixes their ESLint setup
yarn add -D eslint-config-react-app eslint
as well.

I wanted to check when it was fixed but that's apparently not allowed.

$ yarn dlx create-react-app@5.0.0 my-cra
You are running `create-react-app` 5.0.0, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

@merceyz
merceyz enabled auto-merge August 11, 2024 09:46
@merceyz merceyz mentioned this pull request Aug 11, 2024
3 tasks done
@merceyz merceyz mentioned this pull request Oct 6, 2024
1 of 3 tasks
@arcanis

arcanis commented Feb 17, 2025

Copy link
Copy Markdown
Member

I removed the E2E CRA since it's now officially deprecated.

@arcanis arcanis closed this Feb 17, 2025
auto-merge was automatically disabled February 17, 2025 10:25

Pull request was closed

@merceyz
merceyz deleted the clemyan/e2e/cra branch February 17, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants