Repository navigation
Fix CRA E2E test - #6423
Closed
clemyan wants to merge 3 commits into
Closed
Fix CRA E2E test#6423clemyan wants to merge 3 commits into
clemyan wants to merge 3 commits into
Conversation
Member
|
Great that we don't need to install those ourselves anymore, we had to install both before (ref #3988). berry/.github/workflows/e2e-storybook-workflow.yml Lines 32 to 33 in 9b7b745 berry/.github/workflows/e2e-cra-workflow.yml Lines 41 to 42 in 9b7b745 I wanted to check when it was fixed but that's apparently not allowed. $ yarn dlx create-react-app@5.0.0 my-cra
You are running `create-react-app` 5.0.0, which is behind the latest release (5.0.1).
We no longer support global installation of Create React App. |
merceyz
approved these changes
Jul 30, 2024
merceyz
enabled auto-merge
August 11, 2024 09:46
3 tasks done
Member
|
I removed the E2E CRA since it's now officially deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The CRA E2E test has been failing. CRA only supports ESLint up to v8
How did you fix it?
Stop installing
eslintourselves --react-scriptsdepends on it already.As far as I can tell,
eslint-config-react-appalso don't need to be installed explicitly nowChecklist