Fix peer warning message requester #6376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When an incompatible peer warning occurs, the warning message shown during install simply uses the first peer requester found but that may not have any relation to the unsatisfied request.
See #6205 (comment) (partial fix)
How did you fix it?
Actually find the first unsatisfied requester, prioritizing root requesters (i.e. direct dependencies).
If an unsatisfied root requester is found, the warning message looks similar to 4.2.2
If all root requesters are satisfied, then an unsatisfied requester is found and reported with one of the corresponding root requesters
One concern I had was that it will make the message longer, but we are already way past the common terminal width so I don't think that's a big issue.
Checklist