test(core): avoid mocking got
#5585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
added a commit
that referenced
this pull request
Oct 21, 2023
**What's the problem this PR addresses?** One of our tests mocks `got` to validate that it is passed the correct URL which doesn't work when transpiled by esbuild. We have a test that checks that the URL is correct using `wrapNetworkRequest` and various integration tests that should cover it. Extracted from #5581 **How did you fix it?** Removed the test that required mocking `got`. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed. (cherry picked from commit 0dc8b6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
One of our tests mocks
gotto validate that it is passed the correct URL which doesn't work when transpiled by esbuild.We have a test that checks that the URL is correct using
wrapNetworkRequestand various integration tests that should cover it.Extracted from #5581
How did you fix it?
Removed the test that required mocking
got.Checklist