feat(essentials): add preferReuse setting
#4221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionebl
changed the title
merceyz
changed the title
preferReuse setting
merceyz
requested changes
Mar 31, 2022
Member
merceyz
left a comment
merceyz
left a comment
There was a problem hiding this comment.
Thanks for the PR, I really appreciate that you included a test and updated the JSON schema.
I have a few comments but otherwise this looks good.
packages/acceptance-tests/pkg-tests-specs/sources/commands/add.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
merceyz
requested changes
Mar 31, 2022
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Member
|
LGTM! Thanks @marionebl! |
merceyz
added a commit
that referenced
this pull request
Oct 22, 2023
* feat: expose preferReuse and preferCached * chore: add release data * remove preferCached * remove preferCached from config * set all release strategies * add default * add test * remove unused * docs: improve explanation Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * style: inline type predicate Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * refactor: remove unused Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * fix: move preferReuse config * refactor: use makeTemporaryEnv config creator * fix: remove unused * docs: improve explanation Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * fix: escape ` Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> (cherry picked from commit 5681a5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I want to keep dependencies across all workspaces in sync as much as possible; working with a larger number of collaborators often means
preferInteractiveis not enough to reuse existing versions.--cachedfits the bill but there is no option to enable it by default.E.g. for a scenario where
react@16is present somewhere in the project I want to installreact@16overreact@17given the command...
How did you fix it?
preferReuseoptions...
Checklist