Skip to content

fix(core): handle workspaces set to null #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix(core): handle workspaces set to null #4039

merged 1 commit into from
Jan 31, 2022

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented Jan 30, 2022

What's the problem this PR addresses?

Yarn crashes if the workspaces field is set to null.

Fixes #3947

How did you fix it?

Check that workspaces isn't null before trying to access its properties

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner January 30, 2022 16:39
@arcanis arcanis merged commit 093e8bb into master Jan 31, 2022
@arcanis arcanis deleted the merceyz/fix/manifest-workspaces-null branch January 31, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arcanis arcanis Awaiting requested review from arcanis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uncaught Type Error when setting workspaces manifest property to null [Bug?]:

3 participants

@merceyz @arcanis