[Bug?]: Yarn with pnp linker wants to delete mountpoint of `node_modules/.cache`

[loynoir]

Self-service

• I'd be willing to implement a fix

Describe the bug

yarn berry want to delete docker volume

To reproduce

$ cd `mktemp -d`
$ g=node:18.11.0-alpine3.16@sha256:828424b660b8274e7dcf6c7447f014406610facf663f38df92c3162a3d29a1db
$ mkdir -p node_modules
$
$ docker run --rm -it -v "$PWD":/app  -v node_modules:/app/node_modules -w /app "$g" sh
/app # apk add git
/app # yarn init -2
/app # yarn --version
3.2.4
/app # node --version
v18.11.0
/app # yarn
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0031: │ One or more node_modules have been detected and will be removed. This operation may take some time.
➤ YN0001: │ Error: EBUSY: resource busy or locked, rmdir '/app/node_modules'
➤ YN0000: └ Completed in 1s 24ms
➤ YN0000: Failed with errors in 1s 73ms

$ yarn
Error: EBUSY: resource busy or locked, rmdir '/path/to/node_modules'

Environment

$ yarn --version
3.2.4
$ node --version
18.9.1

Additional context

#4259
#4172

[larixer]

I cannot reproduce, please include full reproduction steps

[loynoir]

?

$ cd `mktemp -d`
$ g=node:18.11.0-alpine3.16@sha256:828424b660b8274e7dcf6c7447f014406610facf663f38df92c3162a3d29a1db
$ mkdir -p node_modules
$
$ docker run --rm -it -v "$PWD":/app  -v node_modules:/app/node_modules -w /app "$g" sh
/app # apk add git
/app # yarn init -2
/app # yarn --version
3.2.4
/app # node --version
v18.11.0
/app # yarn
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0031: │ One or more node_modules have been detected and will be removed. This operation may take some time.
➤ YN0001: │ Error: EBUSY: resource busy or locked, rmdir '/app/node_modules'
➤ YN0000: └ Completed in 1s 24ms
➤ YN0000: Failed with errors in 1s 73ms

[larixer]

?

?

Yarn 3+ uses pnp install strategy by default and you seem to want Yarn 1/npm-style node_modules, you should enable this via nodeLinker: node-modules:

/app # echo 'nodeLinker: node-modules' >> .yarnrc.yml
/app # yarn
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed in 0s 283ms
➤ YN0000: Done in 0s 323ms

[loynoir]

That mountpoint exists for pattern node_modules/.cache which used by esbuild and prettier.

/app $ tree -a node_modules
node_modules  [error opening dir]
0 directories, 0 files
/app $ yarn add -D esbuild prettier
/app $ tree -a node_modules
node_modules
└── .cache
    └── esbuild
        └── pnpapi-esbuild-linux-64-0.15.12-esbuild

2 directories, 1 file
/app $ yarn prettier -w package.json
/app $ tree -a node_modules
node_modules
└── .cache
    ├── esbuild
    │   └── pnpapi-esbuild-linux-64-0.15.12-esbuild
    └── prettier

3 directories, 1 file