Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template documentation links with spaces are broken #163

Closed
sebastian-berlin-wmse opened this issue Mar 1, 2022 · 1 comment
Closed
Milestone

Comments

@sebastian-berlin-wmse
Copy link
Contributor

Clicking on "Template documentation" in the "Choose column" step splits templates containing spaces. The result is two tabs, one with the each part of the URL.

Steps to reproduce:

  • Click "Generate Spreadsheet".
  • Add any directory and click "Next".
  • In the "Choose columns" pane under "Template", click "Art Photo".
  • Click "Template documentation".

Actual result

Two new tabs are opened, one with the URL https://commons.wikimedia.org/wiki/Template:Art and one with photo/doc.

Expected result

One tab opens with the URL https://commons.wikimedia.org/wiki/Template:Art Photo/doc.

More information

I have only tried this on Ubuntu 20.04 and with Forefox 97.0 as default browser. There is nothing in log about this. Maybe there should be an entry when opening a URL.

Abbe98 added a commit to Abbe98/pattypan that referenced this issue Mar 1, 2022
@Abbe98 Abbe98 added this to the 22.03 milestone Mar 1, 2022
@Abbe98
Copy link
Collaborator

Abbe98 commented Mar 1, 2022

A fix (#164) will be available in the next release.

Abbe98 added a commit that referenced this issue Mar 24, 2022
Fix: templates with spaces in name breaks documentation links #163
@Abbe98 Abbe98 closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants