forked from keras-team/keras
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to infer the output shape for Deconvolution2D layer #4
Open
lukovkin
wants to merge
15
commits into
yaringal:master
Choose a base branch
from
lukovkin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c797487
ENH: Infer output shape for Deconvolution2D
111060f
BUG: Tensor doesn't have 'shape' property, using K.shape() instead
lukovkin ab29be6
BUG: Fix subsample index for cols
b654a2a
BUG: Fix subsample index for cols
fcc1908
BUG: Fix subsample index for cols
af03021
Merge branch 'master' of https://github.com/lukovkin/keras
26b9c44
ENH: Update Deconvolution2D test case in order to test w and w/o outp…
01fda37
ENH: Update Deconvolution2D test case in order to test w and w/o outp…
lukovkin c117361
Merge branch 'master' of https://github.com/lukovkin/keras
4818bff
Merge branch 'master' of https://github.com/yaringal/keras into yarin…
lukovkin 463a550
DOC: Reference for Deconvolution2D added
lukovkin 9ffce28
ENH: Filter rows and cols as variables in Deconvolution2D test case
lukovkin 5d00fb7
Create dummy
lukovkin 5a606c6
BUG: Possible non-compliance between filter_shape passed as a paramet…
lukovkin 810ca65
BUG: Fixed output_shape elements evaluation
lukovkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a kind of inconsistency here - we receive the filter_shape as a parameter, after that we reshape the kernel itself (shape should change) but leave filter_shape intact and pass it to the AbstractConv2d_gradInputs then.
Probably we could totally remove filter_shape from the parameters, if there are no other reasons to use it.