Attempt to infer the output shape for Deconvolution2D layer #4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1054,11 +1054,15 @@ def deconv2d(x, kernel, output_shape, strides=(1, 1), | |
| np_kernel = kernel.eval() | ||
| filter_shape = _preprocess_filter_shape(dim_ordering, shape(kernel)) | ||
|
|
||
| _t = () | ||
| for v in output_shape: | ||
| try: | ||
| _v = v.eval() | ||
|
There was a problem hiding this comment. Here I stuck probably the same issue that @yaringal mentioned - if we infer output_shape, it becomes the tuple of Theano variables/expressions, which Theano couldn't accept as an input due to some reasons.
I'm not an expert in Theano, so have no idea how to fix it quick. |
||
| except AttributeError as e: | ||
| _v = v | ||
| print(e.__str__()) | ||
| _t = _t + (v, ) | ||
| output_shape = _t | ||
|
|
||
| print("imshp {} kshp {} subsample {} border_mode {} output_shape {}".format(output_shape, filter_shape, strides, th_border_mode, output_shape[2:])) | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a kind of inconsistency here - we receive the filter_shape as a parameter, after that we reshape the kernel itself (shape should change) but leave filter_shape intact and pass it to the AbstractConv2d_gradInputs then.
Probably we could totally remove filter_shape from the parameters, if there are no other reasons to use it.