THT Resistor Bands and Vertical #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think this looks slightly better. Thoughts on improvement? (especially for the taller large ones) |
Owner
|
I think they look OK. One proposal - maybe adding a gradient to a darker color on one side or a thicker outline could increase the contrast between PCB and the resistor. Especially the resistors without the bands seem to blend with the PCB. |
Contributor
Author
|
I went back and re-did how the generator generates the resistors, mostly because the outline did not look right when scaled (got squished to one side). I also ever so slightly darkened the resistor up, not sure how low I should go before it looks too orange |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 5-color code bands and a zero/short band to the existing horizontal through-hole resistor models. The 5-color bands or the zero band is displayed by my fork of PCBdraw, see yaqwsx/PcbDraw#156
This change is meant to be backwards compatible with the current implementation of coloring in pcbdraw.
This PR also adds some more resistor sizes, after checking that they are indeed the "bean" type in KiCAD. Proportions are off, so I need to fix that (perhaps even make a new template for those larger sizes)
This PR also adds vertical resistors.
Latest image:
TODO: