Skip to content

Conversation

@rubienr
Copy link
Member

@rubienr rubienr commented Jun 3, 2022

Description

Type of change

  • cleanup or refactoring (non-breaking change)
  • new feature (non-breaking change which adds functionality)

Tests to verify changes

  • unit tests
    • test_parse_get_uplink_frequency_01
    • test_parse_get_downlink_frequency_01
    • test_parse_get_uplink_mode_01
    • test_parse_get_downlink_mode_01
    • test_parse_get_uplink_radio_01
    • test_parse_get_downlink_radio_01
    • test_parse_get_time_01
  • integration tests
    • _test_easycomm2_rotctl_v34_get_uplink_frequency
    • _test_easycomm2_rotctl_v34_get_downlink_frequency
    • _test_easycomm2_rotctl_v34_get_uplink_mode
    • _test_easycomm2_rotctl_v34_get_downlink_mode
    • _test_easycomm2_rotctl_v34_get_uplink_radio
    • _test_easycomm2_rotctl_v34_get_downlink_radio
    • _test_easycomm2_rotctl_v34_get_time

Checklist

  • I have installed the pre-commit hook or at least run it manually: pre-commit install or pre-commit run --all-files
  • my code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas and public interface
  • I have made corresponding changes to the documentation
  • my changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • new and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Testing

  • unit tests:
    • in GitHub CI: triggered on commit
    • on your machine: pio test -e native
    • pio test -e megaatmega2560
    • pio test -e ststm32
    • pio test -e espressif8266
    • pio test -e espressif32
  • integration tests:
    • in GitHub CI: triggered on commit
    • on your machine: pio run -e native -t integration

@rubienr rubienr merged commit 84e9678 into main Jun 3, 2022
@rubienr rubienr deleted the implements-missing-commands branch June 3, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] implement get UR/DR radio [FR] implement get UM/DM mode [FR] implement get UP/DN frequency

2 participants