Re-hydration from previous state #73

Activity

1. fieldju commented on Feb 4, 2020

   

   fieldju

   on Feb 4, 2020

   Last edited by fieldju

   Member

   More actions

   This sounds reasonable. I really dislike the method name toJson that all the metrics impl, because some of them do NOT return JSON, should really be getValue() or getPayload().

   Since this lib is inspired from Dropwizard see: https://github.com/dropwizard/metrics/blob/4.1-development/metrics-core/src/main/java/com/codahale/metrics/Gauge.java#L25

   So maybe the static initializer could be fromValue.

   👍React with 👍1Reacted by Paulo Cesar
2. pocesar commented on Feb 4, 2020

   

   pocesar

   on Feb 4, 2020

   Author

   More actions

   recreating the internal representation is harder than I expected, there are too many moving parts (new class instances, and their internals as well)