Bug: Webhooks `InstallationCreated` field `requester` schema error

[birkjernstrom]

Hi,

First of all: Thanks for an amazing effort and contribution creating this library! I had the same idea a few weeks ago before I fortunately stumbled over this one <3

Issue

• Receiving a Webhook of type installation.created
• requester is null (None) in the webhook received
• Pydantic throws a validation error that requester cannot be None

Proposal

Change template to expand Unset to Unset, None within the Union type definitions and set None as the default? Or change the validator to check for is None as well UNSET?

[birkjernstrom]

Happy to make a PR for this. Just not 100% sure I'm following the intent with Unset and whether I'm thinking about it correctly or if there is a better approach

[yanyongyu]

Hi, thank you for finding an error in webhooks schema. githubkit generates the webhooks model from https://github.com/octokit/webhooks. I find the error schema field here. octokit seems to assume this field to be User, not null. If you actually received a null value, i can make a schema patch in the pyproject.toml file.

[yanyongyu]

I find the example model in github docs. This field is object or null.

[yanyongyu]

A new release is published which has fixed this error. By the way, UNSET means field missing in data, None means that the field exists in the data with a value null. So, the default value for optional field should be UNSET.

If you find any other schema error in model definitions, welcome to open an issue or pull request! 😄

[birkjernstrom]

Thank you so much @yanyongyu ! Sorry for the late response, it got completely lost amongst notifications.