Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests below were found flaky because of the ordering of HashSets and HashMaps. The orders of elements in the HashSets and HashMaps are not the same every time being called. In this case,
HashSetis changed intoLinkedHashSet, and the unordered results fromHashMapare sorted for comparing. This code change is trying to fix the flaky tests mentioned above, because they sometimes fail (as the picture showed) and sometimes pass when comparing the strings. The failure could be reproduced by the commands above by using the tool of NonDex. The code change is to make sure the tests will always pass in this case.org.modelmapper.internal.converter.ArrayConverterTest.shouldConvertFromSetorg.modelmapper.internal.TypeInfoImplTest.shouldProduceMutatorsorg.modelmapper.internal.TypeInfoImplTest.shouldProduceAccessorsThe test failures could be reproduced by
mvn install -pl . -am -DskipTestsmvn -pl core edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.modelmapper.internal.TypeInfoImplTest#shouldProduceAccessors