Fixed crash bug when a QR Code string could not be decoded and result… #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in unwrapping of nil. Also added border color change to indicate the issue with a red color.
|
Thank you for pointing this. I never had problem with the string decoding before, and I don't know how this is possible. But thank you for the fixing. I'll push a new release this w-e I think. 👍 I believe Qrafter uses its own scanner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed in unwrapping of nil.
Also added border color change to indicate the issue with a red color.
As stated by Apple, the AVMetadataMachineReadableCodeObject.string can actually be nil and in that case, the previous code would crash.
I have not yet managed to figure out why the QRCode string could not be decoded. I have a particular QRCode from the Hermes Parcel Service with my own full address and that of another person, so I can naturally not attach that for debug purposes :-)
I suspect that either Hermes is doing something weird or there is a problem with the string encoding, which Apples framework does not handle correctly.
I tried to scan the QRCode with the Qrafter App and that actually worked, but I do not know what kind of code scanner it uses.
OK, before this gets tl;dr; - please consider releasing at least the unwrapping safe guard. The overlay border color change is a nice to have (for the user) to see that a code was found but could not be read.