Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with install via Swift Package Manager #48

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

rcasula
Copy link
Contributor

@rcasula rcasula commented Jul 5, 2019

This fixes #47

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          75     75           
=====================================
  Hits           75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543af9e...322ffde. Read the comment docs.

@yannickl
Copy link
Owner

yannickl commented Jul 8, 2019

@robcas3 thank you for your help. Your commit does not fix #47 but it only bumps the PromiseKit version.

@yannickl yannickl merged commit 83cceed into yannickl:master Jul 8, 2019
@rcasula
Copy link
Contributor Author

rcasula commented Jul 9, 2019

Well, thanks @yannickl.
But now I can install it from Xcode 11 beta 3, for me fixes the problem.
Why you said that does not fixes it?

The PromiseKit version bump was a side effect.
The real fix was to modify the PK Version in the changelog from 6.7 to 6.7.0.
For some inexplicable reason Xcode seems to read the changelog.

@yannickl
Copy link
Owner

yannickl commented Jul 9, 2019

@robcas3 it was my fault. It only misses the SPM version in the package but it was working. It was late and I was tired. :$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install via Swift Package Manager
2 participants